github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not DCHECK production-necessary methods (#20836)

Browse Source
This commit is contained in:
trop[bot]
2019-10-29 14:49:12 -07:00
committed by Shelley Vohr
parent 9b74d0d54a
commit 3aa33dd220
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/renderer/atom_renderer_client.cc
View File

@@ -121,7 +121,9 @@ void AtomRendererClient::DidCreateScriptContext(
node::tracing::TraceEventHelper::SetAgent(node::CreateAgent());
// Setup node environment for each window.
DCHECK(node::InitializeContext(renderer_context));
bool initialized = node::InitializeContext(renderer_context);
CHECK(initialized);
node::Environment* env =
node_bindings_->CreateEnvironment(renderer_context, nullptr, true);

3
shell/renderer/web_worker_observer.cc
View File

@@ -48,7 +48,8 @@ void WebWorkerObserver::ContextCreated(v8::Local<v8::Context> worker_context) {
node_bindings_->PrepareMessageLoop();
// Setup node environment for each window.
DCHECK(node::InitializeContext(worker_context));
bool initialized = node::InitializeContext(worker_context);
CHECK(initialized);
node::Environment* env =
node_bindings_->CreateEnvironment(worker_context, nullptr, true);