feat: add session.removeWordFromSpellCheckerDictionary API (#22368)

* feat: add session.removeWordFromSpellCheckerDictionary API

* rebase fixup
This commit is contained in:
Erick Zhao
2020-03-02 14:46:19 -08:00
committed by GitHub
parent 5e05df9f71
commit 3d65d84193
3 changed files with 26 additions and 0 deletions

View File

@@ -504,6 +504,14 @@ Returns `Boolean` - Whether the word was successfully written to the custom dict
**Note:** On macOS and Windows 10 this word will be written to the OS custom dictionary as well
#### `ses.removeWordFromSpellCheckerDictionary(word)`
* `word` String - The word you want to remove from the dictionary
Returns `Boolean` - Whether the word was successfully removed from the custom dictionary.
**Note:** On macOS and Windows 10 this word will be removed from the OS custom dictionary as well
#### `ses.loadExtension(path)`
* `path` String - Path to a directory containing an unpacked Chrome extension

View File

@@ -852,6 +852,21 @@ bool Session::AddWordToSpellCheckerDictionary(const std::string& word) {
return spellcheck->GetCustomDictionary()->AddWord(word);
}
bool Session::RemoveWordFromSpellCheckerDictionary(const std::string& word) {
SpellcheckService* service =
SpellcheckServiceFactory::GetForContext(browser_context_.get());
if (!service)
return false;
#if BUILDFLAG(USE_BROWSER_SPELLCHECKER)
if (spellcheck::UseBrowserSpellChecker()) {
spellcheck_platform::RemoveWord(service->platform_spell_checker(),
base::UTF8ToUTF16(word));
}
#endif
return service->GetCustomDictionary()->RemoveWord(word);
}
#endif
// static
@@ -942,6 +957,8 @@ void Session::BuildPrototype(v8::Isolate* isolate,
&Session::ListWordsInSpellCheckerDictionary)
.SetMethod("addWordToSpellCheckerDictionary",
&Session::AddWordToSpellCheckerDictionary)
.SetMethod("removeWordFromSpellCheckerDictionary",
&Session::RemoveWordFromSpellCheckerDictionary)
#endif
.SetMethod("preconnect", &Session::Preconnect)
.SetProperty("cookies", &Session::Cookies)

View File

@@ -98,6 +98,7 @@ class Session : public gin_helper::TrackableObject<Session>,
const std::vector<std::string>& languages);
v8::Local<v8::Promise> ListWordsInSpellCheckerDictionary();
bool AddWordToSpellCheckerDictionary(const std::string& word);
bool RemoveWordFromSpellCheckerDictionary(const std::string& word);
#endif
#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)