github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky macOS dock tests (#50098)

Browse Source 
* test: fix flaky mac dock & autofill tests

* fix: add null checks for the parent widget before calling IsVisible()

* test: remove autofill test change (failing on Linux), keep crash fix

* chore: autofill updates from code review
This commit is contained in:
Keeley Hammond
2026-03-06 13:35:16 -08:00
committed by GitHub
parent 86f2c7cced
commit 3e0e1e4e84
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/ui/views/autofill_popup_view.cc
View File

@@ -67,9 +67,11 @@ AutofillPopupView::~AutofillPopupView() {
}
void AutofillPopupView::Show() {
if (!popup_)
return;
bool visible = parent_widget_->IsVisible();
visible = visible || view_proxy_;
if (!popup_ || !visible || parent_widget_->IsClosed())
if (!visible || parent_widget_->IsClosed())
return;
const bool initialize_widget = !GetWidget();

6
spec/api-app-spec.ts
View File

@@ -1850,15 +1850,13 @@ describe('app module', () => {
});
it('should return a positive number for informational type', () => {
const appHasFocus = !!BrowserWindow.getFocusedWindow();
if (!appHasFocus) {
if (!app.isActive()) {
expect(app.dock?.bounce('informational')).to.be.at.least(0);
}
});
it('should return a positive number for critical type', () => {
const appHasFocus = !!BrowserWindow.getFocusedWindow();
if (!appHasFocus) {
if (!app.isActive()) {
expect(app.dock?.bounce('critical')).to.be.at.least(0);
}
});