github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: [gn] only define WIN32_LEAN_AND_MEAN if not already defined (#13430)

Browse Source 
Chromium's GN build already defines `WIN32_LEAN_AND_MEAN` and `NOMINMAX` (see [build/config/win/BUILD.gn](dbe762aaff/build/config/win/BUILD.gn (515)) in chrome), so we don't need to define them ourselves. Left as #ifndefs so as not to break the gyp build.
This commit is contained in:
Jeremy Apthorp
2018-06-26 02:00:50 +02:00
committed by GitHub
parent 78bc1081fd
commit 418c4e170c
3 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.cc
View File

@@ -1,5 +1,9 @@
#ifndef NOMINMAX
#define NOMINMAX
#endif
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#include "brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.h"
#include <windowsx.h>
#include <algorithm>

2
brightray/browser/win/win32_desktop_notifications/toast.cc
View File

@@ -1,4 +1,6 @@
#ifndef NOMINMAX
#define NOMINMAX
#endif
#include "brightray/browser/win/win32_desktop_notifications/toast.h"
#include <uxtheme.h>
#include <windowsx.h>

2
brightray/browser/win/win32_notification.cc
View File

@@ -1,4 +1,6 @@
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#include "brightray/browser/win/win32_notification.h"