github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: run Node.js at-exit callbacks in renderer proc (#23564)

Browse Source
This commit is contained in:
Shelley Vohr
2020-05-14 07:08:34 -07:00
committed by GitHub
parent faf2871efe
commit 42ab97f905
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/renderer/electron_renderer_client.cc
View File

@@ -176,8 +176,11 @@ void ElectronRendererClient::WillReleaseScriptContext(
// avoid memory leaks
auto* command_line = base::CommandLine::ForCurrentProcess();
if (command_line->HasSwitch(switches::kNodeIntegrationInSubFrames) ||
command_line->HasSwitch(switches::kDisableElectronSiteInstanceOverrides))
command_line->HasSwitch(
switches::kDisableElectronSiteInstanceOverrides)) {
node::RunAtExit(env);
node::FreeEnvironment(env);
}
// ElectronBindings is tracking node environments.
electron_bindings_->EnvironmentDestroyed(env);