github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't convert values with internal fields

Browse Source
This commit is contained in:
Kevin Sawicki
2016-08-26 09:26:58 -07:00
parent b5dec9990e
commit 4579ec6094
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
atom/common/native_mate_converters/v8_value_converter.cc
View File

@@ -393,6 +393,19 @@ base::Value* V8ValueConverter::FromV8Object(
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
v8::Local<v8::Array> property_names(val->GetOwnPropertyNames());
// Don't consider DOM objects. This check matches isHostObject() in Blink's
// bindings/v8/V8Binding.h used in structured cloning. It reads:
//
// If the object has any internal fields, then we won't be able to serialize
// or deserialize them; conveniently, this is also a quick way to detect DOM
// wrapper objects, because the mechanism for these relies on data stored in
// these fields.
//
// ANOTHER NOTE: returning an empty dictionary here to minimise surprise.
// See also http://crbug.com/330559.
if (val->InternalFieldCount())
return result.release();
for (uint32_t i = 0; i < property_names->Length(); ++i) {
v8::Local<v8::Value> key(property_names->Get(i));