github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-27 16:28:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

HandleCommand now takes session_id and returns success boolean. It is assumed a nullptr from the handler means failure

Browse Source
This commit is contained in:
Samuel Attard
2017-12-18 11:00:20 +11:00
committed by Aleksei Kuzmin
parent ed992ae6a1
commit 461e33104e
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
brightray/browser/devtools_manager_delegate.cc
View File

@@ -103,10 +103,14 @@ DevToolsManagerDelegate::~DevToolsManagerDelegate() {
void DevToolsManagerDelegate::Inspect(content::DevToolsAgentHost* agent_host) {
}
base::DictionaryValue* DevToolsManagerDelegate::HandleCommand(
bool DevToolsManagerDelegate::HandleCommand(
content::DevToolsAgentHost* agent_host,
int session_id,
base::DictionaryValue* command) {
return handler_->HandleCommand(agent_host, command);
if (handler_->HandleCommand(agent_host, command)) {
return true;
}
return false;
}
scoped_refptr<content::DevToolsAgentHost>

3
brightray/browser/devtools_manager_delegate.h
View File

@@ -24,8 +24,9 @@ class DevToolsManagerDelegate : public content::DevToolsManagerDelegate {
// DevToolsManagerDelegate implementation.
void Inspect(content::DevToolsAgentHost* agent_host) override;
base::DictionaryValue* HandleCommand(
bool HandleCommand(
content::DevToolsAgentHost* agent_host,
int session_id,
base::DictionaryValue* command) override;
scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(
const GURL& url) override;