github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove additional URL parsing entirely when showing dialogs

Browse Source
This commit is contained in:
Noah Gregory
2026-03-06 16:23:44 -05:00
parent 7f84770c1d
commit 46b92bf2d1
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/browser/api/web-contents.ts
View File

@@ -782,9 +782,7 @@ WebContents.prototype._init = function () {
const originCounts = new Map<string, number>();
const openDialogs = new Set<AbortController>();
this.on('-run-dialog', async (info, callback) => {
const originUrl = new URL(info.frame.url || `unknown:${info.frame.processId}:${info.frame.routingId}`);
// By spec, a URL origin may be "null" (an "opaque origin") in some cases, so we use the href as a fallback.
const origin = originUrl.origin === 'null' ? originUrl.href : originUrl.origin;
const origin = info.frame.origin === 'file:' ? info.frame.url : info.frame.origin;
if ((originCounts.get(origin) ?? 0) < 0) return callback(false, '');
const prefs = this.getLastWebPreferences();