github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-02-16 01:56:59 -05:00
Code Issues Packages Projects Releases Wiki Activity

Guard against non-constructor call in Constructor::New

Browse Source
This commit is contained in:
Cheng Zhao
2014-10-30 21:54:29 +08:00
parent b1f7cfa9da
commit 4a1d11b2be
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
native_mate/arguments.h
View File

@@ -60,6 +60,10 @@ class Arguments {
return info_->This();
}
bool IsConstructCall() const {
return info_->IsConstructCall();
}
int Length() const {
return info_->Length();
}

5
native_mate/constructor.h
View File

@@ -151,6 +151,11 @@ class Constructor {
private:
static MATE_METHOD_RETURN_TYPE New(const WrappableFactoryFunction& factory,
v8::Isolate* isolate, Arguments* args) {
if (!args->IsConstructCall()) {
args->ThrowError("Requires constructor call");
MATE_METHOD_RETURN_UNDEFINED();
}
Wrappable* object = internal::InvokeFactory(args, factory);
if (object)
object->Wrap(isolate, args->GetThis());