github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: remove workaround for fixed Menu.closePopup issue (#37846)

Browse Source 
test: remove workaround for fixed Menu.closePopup issue (#37802)
This commit is contained in:
David Sanders
2023-04-06 02:52:18 -07:00
committed by GitHub
parent 0a153e7dca
commit 4fc59bcbef
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spec/api-menu-spec.ts
View File

@@ -816,10 +816,7 @@ describe('Menu module', function () {
it('should emit menu-will-close event', (done) => {
menu.on('menu-will-close', () => { done(); });
menu.popup({ window: w });
// https://github.com/electron/electron/issues/19411
setTimeout(() => {
menu.closePopup();
});
menu.closePopup();
});
it('returns immediately', () => {
@@ -848,18 +845,12 @@ describe('Menu module', function () {
expect(x).to.equal(100);
expect(y).to.equal(101);
// https://github.com/electron/electron/issues/19411
setTimeout(() => {
menu.closePopup();
});
menu.closePopup();
});
it('works with a given BrowserWindow, no options, and a callback', (done) => {
menu.popup({ window: w, callback: () => done() });
// https://github.com/electron/electron/issues/19411
setTimeout(() => {
menu.closePopup();
});
menu.closePopup();
});
it('prevents menu from getting garbage-collected when popuping', async () => {