mirror of
https://github.com/electron/electron.git
synced 2026-01-24 14:57:58 -05:00
Make companyName and submitURL required options
This commit is contained in:
@@ -19,8 +19,6 @@ class CrashReporter
|
||||
{app} = if process.type is 'browser' then electron else electron.remote
|
||||
|
||||
@productName ?= app.getName()
|
||||
companyName ?= 'GitHub, Inc'
|
||||
submitURL ?= 'http://54.249.141.255:1127/post'
|
||||
autoSubmit ?= true
|
||||
ignoreSystemCrashHandler ?= false
|
||||
extra ?= {}
|
||||
@@ -29,6 +27,14 @@ class CrashReporter
|
||||
extra._companyName ?= companyName
|
||||
extra._version ?= app.getVersion()
|
||||
|
||||
unless companyName?
|
||||
deprecate.log('companyName is now a required option to CrashReporter::start')
|
||||
return
|
||||
|
||||
unless submitURL?
|
||||
deprecate.log('submitURL is now a required option to CrashReporter::start')
|
||||
return
|
||||
|
||||
start = => binding.start @productName, companyName, submitURL, autoSubmit, ignoreSystemCrashHandler, extra
|
||||
|
||||
if process.platform is 'win32'
|
||||
@@ -59,6 +65,5 @@ class CrashReporter
|
||||
path.join tmpdir, "#{@productName} Crashes", 'uploads.log'
|
||||
binding._getUploadedReports log
|
||||
|
||||
|
||||
crashRepoter = new CrashReporter
|
||||
module.exports = crashRepoter
|
||||
|
||||
@@ -54,7 +54,10 @@ deprecate.event = (emitter, oldName, newName, fn) ->
|
||||
|
||||
# Print deprecate warning.
|
||||
deprecate.warn = (oldName, newName) ->
|
||||
message = "#{oldName} is deprecated. Use #{newName} instead."
|
||||
deprecate.log("#{oldName} is deprecated. Use #{newName} instead.")
|
||||
|
||||
# Print deprecation message
|
||||
deprecate.log = (message) ->
|
||||
if process.throwDeprecation
|
||||
throw new Error(message)
|
||||
else if process.traceDeprecation
|
||||
@@ -62,4 +65,5 @@ deprecate.warn = (oldName, newName) ->
|
||||
else
|
||||
console.warn "(electron) #{message}"
|
||||
|
||||
|
||||
module.exports = deprecate
|
||||
|
||||
Reference in New Issue
Block a user