github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 23:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: Revert "Enable network sandbox by default on Windows"

Browse Source 
see if this fixes the Windows sandbox issue
This commit is contained in:
John Kleinschmidt
2025-12-04 09:01:09 -05:00
parent 66d1c5dc9d
commit 530ab6af82
2 changed files with 53 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
patches/chromium/.patches
View File

@@ -142,3 +142,4 @@ expose_referrerscriptinfo_hostdefinedoptionsindex.patch
chore_disable_protocol_handler_dcheck.patch
fix_check_for_file_existence_before_setting_mtime.patch
fix_linux_tray_id.patch
revert_enable_network_sandbox_by_default_on_windows.patch

52
patches/chromium/revert_enable_network_sandbox_by_default_on_windows.patch Normal file
View File

@@ -0,0 +1,52 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: John Kleinschmidt <kleinschmidtorama@gmail.com>
Date: Thu, 4 Dec 2025 08:55:45 -0500
Subject: Revert "Enable network sandbox by default on Windows"
This reverts commit c6bd7f09744da20cbba08c7ffe86537885f4353d.
diff --git a/sandbox/policy/features.cc b/sandbox/policy/features.cc
index bd1e82c4116ed9550205752ba6f2735c36822f24..93b814e8e44f2dc62c18e248f9984097ee539350 100644
--- a/sandbox/policy/features.cc
+++ b/sandbox/policy/features.cc
@@ -17,13 +17,7 @@ namespace sandbox::policy::features {
#if !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_FUCHSIA)
// Enables network service sandbox.
// (Only causes an effect when feature kNetworkServiceInProcess is disabled.)
-BASE_FEATURE(kNetworkServiceSandbox,
-#if BUILDFLAG(IS_WIN)
- base::FEATURE_ENABLED_BY_DEFAULT
-#else
- base::FEATURE_DISABLED_BY_DEFAULT
-#endif // BUILDFLAG(IS_WIN)
-);
+BASE_FEATURE(kNetworkServiceSandbox, base::FEATURE_DISABLED_BY_DEFAULT);
#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
// Enables a fine-grained seccomp-BPF syscall filter for the network service.
diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
index f1fffffa9ea746dc6a403ce5e2e429de57dc1a8a..59d8c855a0984db2f6c20cf406405695f9fdce3b 100644
--- a/testing/variations/fieldtrial_testing_config.json
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -16431,6 +16431,21 @@
]
}
],
+ "NetworkServiceSandboxWindows": [
+ {
+ "platforms": [
+ "windows"
+ ],
+ "experiments": [
+ {
+ "name": "Enabled_20231025",
+ "enable_features": [
+ "NetworkServiceSandbox"
+ ]
+ }
+ ]
+ }
+ ],
"NetworkServiceTaskScheduler2": [
{
"platforms": [