github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent crash in ListValue v8 converter when conversion fails (#22758)

Browse Source 
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
This commit is contained in:
trop[bot]
2020-03-19 10:48:26 -04:00
committed by GitHub
parent 920a82a4de
commit 579f7a1899
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/common/native_mate_converters/value_converter.cc
View File

@@ -58,7 +58,7 @@ bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
electron::V8ValueConverter converter;
std::unique_ptr<base::Value> value(
converter.FromV8Value(val, isolate->GetCurrentContext()));
if (value->is_list()) {
if (value && value->is_list()) {
out->Swap(static_cast<base::ListValue*>(value.get()));
return true;
} else {