github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Unsubscribe observer when OffScreenRenderWidgetHostView is destroyed

Browse Source
This commit is contained in:
Cheng Zhao
2016-09-19 16:51:03 +09:00
parent 07a08077a2
commit 5bf746700e
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
atom/browser/osr/osr_render_widget_host_view.cc
View File

@@ -377,6 +377,9 @@ OffScreenRenderWidgetHostView::OffScreenRenderWidgetHostView(
}
OffScreenRenderWidgetHostView::~OffScreenRenderWidgetHostView() {
if (native_window_)
native_window_->RemoveObserver(this);
#if defined(OS_MACOSX)
if (is_showing_)
browser_compositor_->SetRenderWidgetHostIsHidden(true);
@@ -924,4 +927,9 @@ void OffScreenRenderWidgetHostView::OnWindowResize() {
SetSize(size);
}
void OffScreenRenderWidgetHostView::OnWindowClosed() {
native_window_->RemoveObserver(this);
native_window_ = nullptr;
}
} // namespace atom

1
atom/browser/osr/osr_render_widget_host_view.h
View File

@@ -176,6 +176,7 @@ class OffScreenRenderWidgetHostView
// NativeWindowObserver:
void OnWindowResize() override;
void OnWindowClosed() override;
void OnBeginFrameTimerTick();
void SendBeginFrame(base::TimeTicks frame_time,