github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: base::DictionaryValue usage in APNS notifs (#34897)

Browse Source
This commit is contained in:
Shelley Vohr
2022-07-13 12:22:17 +02:00
committed by GitHub
parent afd08c9450
commit 62aeb74d7c
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_push_notifications.h
View File

@@ -39,7 +39,7 @@ class PushNotifications
PushNotifications& operator=(const PushNotifications&) = delete;
#if BUILDFLAG(IS_MAC)
void OnDidReceiveAPNSNotification(const base::DictionaryValue& user_info);
void OnDidReceiveAPNSNotification(const base::Value::Dict& user_info);
void ResolveAPNSPromiseSetWithToken(const std::string& token_string);
void RejectAPNSPromiseSetWithError(const std::string& error_message);
#endif

2
shell/browser/api/electron_api_push_notifications_mac.mm
View File

@@ -53,7 +53,7 @@ void PushNotifications::UnregisterForAPNSNotifications() {
}
void PushNotifications::OnDidReceiveAPNSNotification(
const base::DictionaryValue& user_info) {
const base::Value::Dict& user_info) {
Emit("received-apns-notification", user_info);
}

2
shell/browser/mac/electron_application_delegate.mm
View File

@@ -193,7 +193,7 @@ static NSDictionary* UNNotificationResponseToNSDictionary(
electron::api::PushNotifications::Get();
if (push_notifications) {
electron::api::PushNotifications::Get()->OnDidReceiveAPNSNotification(
electron::NSDictionaryToDictionaryValue(userInfo));
electron::NSDictionaryToValue(userInfo));
}
}