github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

build: use node 18.12 in AppVeyor (23-x-y) (#37282)

Browse Source 
* build: use node18.12 appveyor image

* build: use e-110.0.5481.77-node18
This commit is contained in:
Keeley Hammond
2023-02-15 14:22:31 -08:00
committed by GitHub
parent 9885c1cfe6
commit 657819b10e
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
appveyor-bake.yml
View File

@@ -6,7 +6,7 @@
version: 1.0.{build}
build_cloud: electronhq-16-core
image: e-110.0.5481.77
image: e-111.0.5560.0-node18
environment:
GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
ELECTRON_OUT_DIR: Default

2
appveyor.yml
View File

@@ -29,7 +29,7 @@
version: 1.0.{build}
build_cloud: electronhq-16-core
image: e-110.0.5481.77
image: e-110.0.5481.77-node18
environment:
GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
ELECTRON_OUT_DIR: Default

6
script/prepare-appveyor.js
View File

@@ -14,8 +14,8 @@ const ROLLER_BRANCH_PATTERN = /^roller\/chromium$/;
const DEFAULT_BUILD_CLOUD_ID = '1598';
const DEFAULT_BUILD_CLOUD = 'electronhq-16-core';
const DEFAULT_BAKE_BASE_IMAGE = 'e-111.0.5560.0-2';
const DEFAULT_BUILD_IMAGE = 'e-111.0.5560.0-2';
const DEFAULT_BAKE_BASE_IMAGE = 'e-111.0.5560.0-node18';
const DEFAULT_BUILD_IMAGE = 'e-111.0.5560.0-node18';
const appveyorBakeJob = 'electron-bake-image';
const appVeyorJobs = {
@@ -188,7 +188,7 @@ async function prepareAppVeyorImage (opts) {
const [, CHROMIUM_VERSION] = versionRegex.exec(deps);
const cloudId = opts.cloudId || DEFAULT_BUILD_CLOUD_ID;
const imageVersion = opts.imageVersion || `e-${CHROMIUM_VERSION}`;
const imageVersion = opts.imageVersion || `e-${CHROMIUM_VERSION}-node18`;
const image = await checkAppVeyorImage({ cloudId, imageVersion });
if (image && image.name) {

4
script/setup-win-for-dev.bat
View File

@@ -56,8 +56,8 @@ REM Install Windows SDK
choco install windows-sdk-10-version-2104-all
REM Install nodejs python git and yarn needed dependencies
choco install -y nodejs-lts python2 git yarn
choco install python --version 3.7.9
choco install -y --force nodejs --version=18.12.1
choco install -y python2 git yarn
call C:\ProgramData\chocolatey\bin\RefreshEnv.cmd
SET PATH=C:\Python27\;C:\Python27\Scripts;C:\Python39\;C:\Python39\Scripts;%PATH%