address review

This commit is contained in:
Jeremy Rose
2023-02-07 12:53:07 -08:00
parent 5f480f383f
commit 673b4e8e54
3 changed files with 5 additions and 23 deletions

View File

@@ -4,6 +4,11 @@
Process: [Main](../glossary.md#main-process)
> **Note**
> `BaseWindow` provides a flexible way to compose multiple web views in a
> single window. For windows with only a single, full-size web view, the
> [`BrowserWindow`](browser-window.md) class may be a simpler option.
This module cannot be used until the `ready` event of the `app`
module is emitted.

View File

@@ -33,7 +33,6 @@ export default class BrowserView {
return this.#webContentsView.getBounds();
}
// eslint-disable-next-line @typescript-eslint/no-unused-vars
setAutoResize (options: AutoResizeOptions) {
if (options == null || typeof options !== 'object') { throw new Error('Invalid auto resize options'); }
this.#autoResizeFlags = {

View File

@@ -157,28 +157,6 @@ declare namespace Electron {
}
// Experimental views API
/*
class View {}
class BaseWindow {
constructor(args: {show: boolean})
setContentView(view: View): void
static fromId(id: number): BaseWindow;
static getAllWindows(): BaseWindow[];
isFocused(): boolean;
static getFocusedWindow(): BaseWindow | undefined;
setMenu(menu: Menu): void;
}
class WebContentsView {
constructor(options: BrowserWindowConstructorOptions)
}
namespace Main {
class BaseWindow extends Electron.BaseWindow {}
class View extends Electron.View {}
class WebContentsView extends Electron.WebContentsView {}
}
*/
// Deprecated / undocumented BrowserWindow methods
interface BrowserWindow {
getURL(): string;