github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-25 15:28:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

BrowserWindow.destroy() should not delete window immediately.

Browse Source 
It could cause crash when context menu is showing.
This commit is contained in:
Cheng Zhao
2014-03-25 16:58:34 +08:00
parent e96a3abdf9
commit 679959eeb5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
atom/browser/api/atom_api_window.cc
View File

@@ -127,7 +127,7 @@ void Window::Destroy(const v8::FunctionCallbackInfo<v8::Value>& args) {
UNWRAP_WINDOW_AND_CHECK;
base::ProcessHandle handle = self->window_->GetRenderProcessHandle();
delete self;
base::MessageLoop::current()->DeleteSoon(FROM_HERE, self);
// Make sure the renderer process is terminated, it could happen that the
// renderer process became a zombie.