github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused Locker fields (#39842)

Browse Source 
refactor: remove unused fields, methods in gin_helper::Locker (#39803)

* refactor: remove unused field gin_helper::Locker::g_is_browser_process

refactor: remove unused field gin_helper::Locker::g_is_renderer_process

refactor: make field const gin_helper::Locker::locker_

* refactor: remove unused declaration gin_helper::Locker::new()

refactor: remove unused declaration gin_helper::Locker::delete()

* refactor: make field const electron::JavascriptEnvironment::locker_

* refactor: remove unused #include gin_helper/locker.h
This commit is contained in:
Charles Kerr
2023-09-13 02:52:39 -05:00
committed by GitHub
parent 036a382d66
commit 6a59b373a6
5 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/javascript_environment.h
View File

@@ -49,7 +49,7 @@ class JavascriptEnvironment {
const raw_ptr<v8::Isolate> isolate_;
// depends-on: isolate_
v8::Locker locker_;
const v8::Locker locker_;
std::unique_ptr<MicrotasksRunner> microtasks_runner_;
};

1
shell/common/gin_helper/event_emitter_caller.cc
View File

@@ -4,7 +4,6 @@
#include "shell/common/gin_helper/event_emitter_caller.h"
#include "shell/common/gin_helper/locker.h"
#include "shell/common/gin_helper/microtasks_scope.h"
#include "shell/common/node_includes.h"

7
shell/common/gin_helper/locker.cc
View File

@@ -8,10 +8,9 @@
namespace gin_helper {
Locker::Locker(v8::Isolate* isolate) {
if (electron::IsBrowserProcess())
locker_ = std::make_unique<v8::Locker>(isolate);
}
Locker::Locker(v8::Isolate* isolate)
: locker_{electron::IsBrowserProcess() ? new v8::Locker{isolate}
: nullptr} {}
Locker::~Locker() = default;

7
shell/common/gin_helper/locker.h
View File

@@ -22,12 +22,7 @@ class Locker {
Locker& operator=(const Locker&) = delete;
private:
void* operator new(size_t size);
void operator delete(void*, size_t);
std::unique_ptr<v8::Locker> locker_;
static bool g_is_browser_process;
const std::unique_ptr<v8::Locker> locker_;
};
} // namespace gin_helper

1
shell/common/node_bindings.cc
View File

@@ -30,7 +30,6 @@
#include "shell/common/gin_helper/dictionary.h"
#include "shell/common/gin_helper/event.h"
#include "shell/common/gin_helper/event_emitter_caller.h"
#include "shell/common/gin_helper/locker.h"
#include "shell/common/gin_helper/microtasks_scope.h"
#include "shell/common/mac/main_application_bundle.h"
#include "third_party/blink/renderer/bindings/core/v8/v8_initializer.h" // nogncheck