github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: return path from netLog.stopLogging (#21989)

Browse Source 
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
This commit is contained in:
trop[bot]
2020-01-31 11:22:14 -08:00
committed by GitHub
parent 46a4864b08
commit 6cf8abc3b3
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/browser/api/session.js
View File

@@ -36,8 +36,9 @@ NetLog.prototype.startLogging = function (path, ...args) {
const _originalStopLogging = NetLog.prototype.stopLogging
NetLog.prototype.stopLogging = function () {
const logPath = this._currentlyLoggingPath
this._currentlyLoggingPath = null
return _originalStopLogging.call(this)
return _originalStopLogging.call(this).then(() => logPath)
}
const currentlyLoggingPathDeprecated = deprecate.warnOnce('currentlyLoggingPath')

3
spec-main/api-net-log-spec.ts
View File

@@ -69,7 +69,8 @@ describe('netLog module', () => {
expect(testNetLog().currentlyLoggingPath).to.equal(dumpFileDynamic)
await testNetLog().stopLogging()
const path = await testNetLog().stopLogging()
expect(path).to.equal(dumpFileDynamic)
expect(fs.existsSync(dumpFileDynamic)).to.be.true('currently logging')
})