github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: serialize messages being sent over chrome message ports (#19104)

Browse Source 
Chrome appears to serialize these messages (see #19070) so we should as
well to be consistent and to avoid bugs with Uint8/16 arrays

Fixes #19070
This commit is contained in:
Samuel Attard
2019-07-15 03:05:09 -07:00
committed by Cheng Zhao
parent d0ece2bc93
commit 6d5e494782
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/renderer/chrome-api.ts
View File

@@ -40,10 +40,10 @@ class Port {
})
ipcRendererInternal.on(`CHROME_PORT_POSTMESSAGE_${portId}`, (
_event: Electron.Event, message: string
_event: Electron.Event, message: any
) => {
const sendResponse = function () { console.error('sendResponse is not implemented') }
this.onMessage.emit(message, this.sender, sendResponse)
this.onMessage.emit(JSON.parse(message), this.sender, sendResponse)
})
}
@@ -54,8 +54,8 @@ class Port {
this._onDisconnect()
}
postMessage (message: string) {
ipcRendererInternal.sendToAll(this.tabId, `CHROME_PORT_POSTMESSAGE_${this.portId}`, message)
postMessage (message: any) {
ipcRendererInternal.sendToAll(this.tabId, `CHROME_PORT_POSTMESSAGE_${this.portId}`, JSON.stringify(message))
}
_onDisconnect () {