mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
Guard against attachedCallback firing while handling detachedCallback
This commit is contained in:
@@ -72,9 +72,12 @@ class WebViewImpl {
|
||||
}
|
||||
|
||||
this.webContents = null
|
||||
this.attributes[webViewConstants.ATTRIBUTE_GUESTINSTANCE].setValueIgnoreMutation(undefined)
|
||||
this.beforeFirstNavigation = true
|
||||
this.attributes[webViewConstants.ATTRIBUTE_PARTITION].validPartitionId = true
|
||||
|
||||
// Set guestinstance last since this can trigger the attachedCallback to fire
|
||||
// when moving the webview using element.replaceChild
|
||||
this.attributes[webViewConstants.ATTRIBUTE_GUESTINSTANCE].setValueIgnoreMutation(undefined)
|
||||
}
|
||||
|
||||
// Sets the <webview>.request property.
|
||||
@@ -310,8 +313,8 @@ var registerWebViewElement = function () {
|
||||
}
|
||||
guestViewInternal.deregisterEvents(internal.viewInstanceId)
|
||||
internal.elementAttached = false
|
||||
internal.reset()
|
||||
this.internalInstanceId = 0
|
||||
internal.reset()
|
||||
}
|
||||
proto.attachedCallback = function () {
|
||||
var internal, instance
|
||||
|
||||
Reference in New Issue
Block a user