github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: lagging when using tabbed window (#18314)

Browse Source
This commit is contained in:
Cheng Zhao
2019-05-17 06:20:10 +09:00
committed by Samuel Attard
parent 36f0583077
commit 7521454161
2 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
patches/common/chromium/.patches
View File

@@ -100,3 +100,4 @@ make_--explicitly-allowed-ports_work_with_networkservice.patch
fix_crashes_in_renderframeimpl_onselectpopupmenuitem_s.patch
fix_re-entracy_problem_with_invalidateframesinkid.patch
chore_expose_getcontentclient_to_embedders.patch
tabbed_window_lagging.patch

30
patches/common/chromium/tabbed_window_lagging.patch Normal file
View File

@@ -0,0 +1,30 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Cheng Zhao <zcbenz@gmail.com>
Date: Thu May 16 13:52:12 JST 2019
Subject: tabbed_window_lagging.patch
Fix lagging when using tabbed windows.
Later Chromium has some enhancements on graphics code that fix the lagging
problem, but the changes are split in multiple commits on multiple files and
we can not just cherry-pick them.
Instead I'm just using the dummy fix and it does not seem to have side effects.
diff --git a/ui/views/cocoa/bridged_native_widget.mm b/ui/views/cocoa/bridged_native_widget.mm
index 69c5f1f44d7e..45aba19b2390 100644
--- a/ui/views/cocoa/bridged_native_widget.mm
+++ b/ui/views/cocoa/bridged_native_widget.mm
@@ -1037,6 +1037,12 @@ NSUInteger CountBridgedWindows(NSArray* child_windows) {
// BridgedNativeWidget, ui::CATransactionObserver
bool BridgedNativeWidget::ShouldWaitInPreCommit() {
+ // Fix lagging when using tabbed windows, see the issue for more:
+ // https://github.com/electron/electron/issues/16925
+ if (@available(macOS 10.12, *)) {
+ if ([[window_ tabbedWindows] count] > 0)
+ return false;
+ }
if (!window_visible_)
return false;
if (ca_transaction_sync_suppressed_)