github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-28 08:48:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

views: Don't leak ViewsDelegate.

Browse Source
This commit is contained in:
Cheng Zhao
2014-07-04 21:41:22 +08:00
parent 651ebdde65
commit 7a196933bb
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
brightray/browser/browser_main_parts.cc
View File

@@ -50,9 +50,7 @@ void BrowserMainParts::ToolkitInitialized() {
#endif
#if defined(TOOLKIT_VIEWS)
if (!views::ViewsDelegate::views_delegate)
views::ViewsDelegate::views_delegate = new ViewsDelegate;
views_delegate_.reset(new ViewsDelegate);
wm_state_.reset(new wm::WMState);
#endif
}

5
brightray/browser/browser_main_parts.h
View File

@@ -10,6 +10,10 @@
#include "content/public/browser/browser_main_parts.h"
#if defined(TOOLKIT_VIEWS)
namespace brightray {
class ViewsDelegate;
}
namespace wm {
class WMState;
}
@@ -53,6 +57,7 @@ class BrowserMainParts : public content::BrowserMainParts {
scoped_ptr<WebUIControllerFactory> web_ui_controller_factory_;
#if defined(TOOLKIT_VIEWS)
scoped_ptr<ViewsDelegate> views_delegate_;
scoped_ptr<wm::WMState> wm_state_;
#endif

4
brightray/browser/views/views_delegate.cc
View File

@@ -9,9 +9,13 @@
namespace brightray {
ViewsDelegate::ViewsDelegate() {
DCHECK(!views::ViewsDelegate::views_delegate);
views::ViewsDelegate::views_delegate = this;
}
ViewsDelegate::~ViewsDelegate() {
DCHECK_EQ(views::ViewsDelegate::views_delegate, this);
views::ViewsDelegate::views_delegate = NULL;
}
void ViewsDelegate::SaveWindowPlacement(const views::Widget* window,