github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 07:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve crash loading file based serviceworkers (#20132)

Browse Source
This commit is contained in:
John Kleinschmidt
2019-09-05 21:01:22 -04:00
committed by Cheng Zhao
parent 20e3c519dd
commit 7be1905023
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/net/proxying_url_loader_factory.cc
View File

@@ -695,7 +695,7 @@ void ProxyingURLLoaderFactory::CreateLoaderAndStart(
// Intercept file:// protocol to support asar archives.
if (request.url.SchemeIsFile()) {
asar::CreateAsarURLLoader(request, std::move(loader), std::move(client),
nullptr);
new net::HttpResponseHeaders(""));
return;
}

3
spec/chromium-spec.js
View File

@@ -194,8 +194,7 @@ describe('chromium feature', () => {
})
})
// FIXME(robo/nornagon): re-enable these once service workers work
describe.skip('navigator.serviceWorker', () => {
describe('navigator.serviceWorker', () => {
it('should register for file scheme', (done) => {
w = new BrowserWindow({
show: false,