github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

spec: don't run codesigning spec on forks (#19433)

Browse Source
This commit is contained in:
trop[bot]
2019-07-26 09:33:31 -04:00
committed by John Kleinschmidt
parent 38b6a7bf4f
commit 7e6617be18
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec-main/api-autoupdater-darwin-spec.ts
View File

@@ -22,7 +22,9 @@ describeFn('autoUpdater behavior', function () {
beforeEach(function () {
const result = cp.spawnSync(path.resolve(__dirname, '../script/codesign/get-trusted-identity.sh'))
if (result.status !== 0 || result.stdout.toString().trim().length === 0) {
if (isCI) {
// Per https://circleci.com/docs/2.0/env-vars:
// CIRCLE_PR_NUMBER is only present on forked PRs
if (isCI && !process.env.CIRCLE_PR_NUMBER) {
throw new Error('No valid signing identity available to run autoUpdater specs')
}
this.skip()