fix: 'page-title-updated' event forwarding + documentation (#18318)

This commit is contained in:
trop[bot]
2019-05-21 16:22:45 +09:00
committed by Cheng Zhao
parent a60ad6aeed
commit 7ee06c354e
3 changed files with 15 additions and 2 deletions

View File

@@ -412,9 +412,11 @@ Returns:
* `event` Event
* `title` String
* `explicitSet` Boolean
Emitted when the document changed its title, calling `event.preventDefault()`
will prevent the native window's title from changing.
`explicitSet` is false when title is synthesized from file url.
#### Event: 'close'

View File

@@ -101,6 +101,17 @@ Returns:
Emitted when the document in the given frame is loaded.
#### Event: 'page-title-updated'
Returns:
* `event` Event
* `title` String
* `explicitSet` Boolean
Fired when page title is set during navigation. `explicitSet` is false when
title is synthesized from file url.
#### Event: 'page-favicon-updated'
Returns:

View File

@@ -39,9 +39,9 @@ BrowserWindow.prototype._init = function () {
})
// Change window title to page title.
this.webContents.on('page-title-updated', (event, title) => {
this.webContents.on('page-title-updated', (event, title, ...args) => {
// Route the event to BrowserWindow.
this.emit('page-title-updated', event, title)
this.emit('page-title-updated', event, title, ...args)
if (!this.isDestroyed() && !event.defaultPrevented) this.setTitle(title)
})