github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure stable bounds on Windows when toggling setResizable for frameless windows (#51427)

Browse Source
This commit is contained in:
Mitchell Cohen
2026-05-01 17:06:40 -04:00
committed by GitHub
parent 6ec2b16f8a
commit 7f51178371
3 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
shell/browser/ui/views/win_frame_view.cc
View File

@@ -295,8 +295,7 @@ gfx::Size WinFrameView::GetMaximumSize() const {
}
gfx::Insets WinFrameView::RestoredFrameBorderInsets() const {
if (window_->has_frame() || !window_->has_thick_frame() ||
!window_->IsResizable())
if (window_->has_frame() || !window_->has_thick_frame())
return {};
const int thickness =

7
shell/browser/ui/win/electron_desktop_window_tree_host_win.cc
View File

@@ -124,10 +124,11 @@ bool ElectronDesktopWindowTreeHostWin::GetClientAreaInsets(
// monitors with different DPIs before changing this code.
*insets = gfx::Insets::TLBR(thickness, thickness, thickness, thickness);
return true;
} else if (native_window_view_->has_thick_frame() &&
native_window_view_->IsResizable()) {
} else if (native_window_view_->has_thick_frame()) {
// Grow the insets to support resize targets past the frame edge like in
// windows with standard frames.
// windows with standard frames. Non-resizable windows still get input
// insets for stable bounds and so they can be dragged from outer edges,
// also like in windows with standard frames.
*insets = gfx::Insets::TLBR(0, thickness, thickness, thickness);
return true;
}

14
spec/api-browser-window-spec.ts
View File

@@ -5564,6 +5564,20 @@ describe('BrowserWindow module', () => {
expectBoundsEqual(w.getContentSize(), [10, 10]);
});
it('does not change window size when disabled and enabled for frameless window', () => {
const w = new BrowserWindow({
show: false,
width: 400,
height: 300,
frame: false
});
w.setResizable(false);
expectBoundsEqual(w.getSize(), [400, 300]);
w.setResizable(true);
expectBoundsEqual(w.getSize(), [400, 300]);
});
ifit(process.platform === 'win32')('do not change window with frame bounds when maximized', () => {
const w = new BrowserWindow({
show: true,