github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-24 14:57:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improve error reporting when using invalid argument types for dialog API methods

Browse Source
This commit is contained in:
Sergey Bekrin
2016-03-23 10:44:11 +03:00
parent 6041c7edf9
commit 7f78781800
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/browser/api/dialog.js
View File

@@ -67,9 +67,13 @@ module.exports = {
}
if (options.title == null) {
options.title = '';
} else if (typeof options.title !== 'string') {
throw new TypeError('Title need to be string');
}
if (options.defaultPath == null) {
options.defaultPath = '';
} else if (typeof options.defaultPath !== 'string') {
throw new TypeError('Default path need to be string');
}
if (options.filters == null) {
options.filters = [];
@@ -91,9 +95,13 @@ module.exports = {
}
if (options.title == null) {
options.title = '';
} else if (typeof options.title !== 'string') {
throw new TypeError('Title need to be string');
}
if (options.defaultPath == null) {
options.defaultPath = '';
} else if (typeof options.defaultPath !== 'string') {
throw new TypeError('Default path need to be string');
}
if (options.filters == null) {
options.filters = [];
@@ -125,12 +133,18 @@ module.exports = {
}
if (options.title == null) {
options.title = '';
} else if (typeof options.title !== 'string') {
throw new TypeError('Title need to be string');
}
if (options.message == null) {
options.message = '';
} else if (typeof options.message !== 'string') {
throw new TypeError('Message need to be string');
}
if (options.detail == null) {
options.detail = '';
} else if (typeof options.detail !== 'string') {
throw new TypeError('Detail need to be string');
}
if (options.icon == null) {
options.icon = null;