github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: call node::Stop on exit (#25458)

Browse Source 
* fix: call node::Stop on exit

* also call Stop in node_main

* oop, we were already calling set_can_call_into_js(false)??

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
This commit is contained in:
trop[bot]
2020-09-15 10:25:40 -06:00
committed by GitHub
parent fbd99fbed1
commit 7fc5c468e9
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/app/node_main.cc
View File

@@ -289,7 +289,7 @@ int NodeMain(int argc, char* argv[]) {
node::ResetStdio();
env->set_can_call_into_js(false);
node::Stop(env);
env->stop_sub_worker_contexts();
env->RunCleanup();

1
shell/browser/electron_browser_main_parts.cc
View File

@@ -551,6 +551,7 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {
node_debugger_->Stop();
node_env_->env()->set_trace_sync_io(false);
js_env_->OnMessageLoopDestroying();
node::Stop(node_env_->env());
node_env_.reset();
ElectronBrowserContext::browser_context_map().clear();