github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-26 07:48:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

DRY up temp directory logging

Browse Source
This commit is contained in:
Kevin Sawicki
2016-10-05 14:00:27 -07:00
parent 1afe501a36
commit 81733a523e
4 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
atom/common/crash_reporter/crash_reporter.cc
View File

@@ -36,7 +36,10 @@ void CrashReporter::Start(const std::string& product_name,
}
bool CrashReporter::GetTempDirectory(base::FilePath* path) {
return PathService::Get(base::DIR_TEMP, path);
bool success = PathService::Get(base::DIR_TEMP, path);
if (!success)
LOG(ERROR) << "Cannot get temp directory";
return success;
}
bool CrashReporter::GetCrashesDirectory(

4
atom/common/crash_reporter/crash_reporter_linux.cc
View File

@@ -79,10 +79,8 @@ void CrashReporterLinux::SetUploadParameters() {
void CrashReporterLinux::EnableCrashDumping(const std::string& product_name) {
base::FilePath dumps_path;
if (!GetCrashesDirectory(&dumps_path)) {
LOG(ERROR) << "Cannot get temp directory";
if (!GetCrashesDirectory(&dumps_path))
return;
}
base::CreateDirectory(dumps_path);

6
atom/common/crash_reporter/crash_reporter_mac.mm
View File

@@ -34,15 +34,13 @@ void CrashReporterMac::InitBreakpad(const std::string& product_name,
bool auto_submit,
bool skip_system_crash_handler) {
// check whether crashpad has been initialized.
// Only need to initilize once.
// Only need to initialize once.
if (simple_string_dictionary_)
return;
base::FilePath database_path;
if (!GetCrashesDirectory(product_name, &database_path)) {
LOG(ERROR) << "Cannot get temp directory";
if (!GetCrashesDirectory(product_name, &database_path))
return;
}
if (is_browser_) {
@autoreleasepool {

4
atom/common/crash_reporter/crash_reporter_win.cc
View File

@@ -154,10 +154,8 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,
skip_system_crash_handler_ = skip_system_crash_handler;
base::FilePath temp_dir;
if (!GetTempDirectory(&temp_dir)) {
LOG(ERROR) << "Cannot get temp directory";
if (!GetTempDirectory(&temp_dir))
return;
}
base::string16 pipe_name = base::ReplaceStringPlaceholders(
kPipeNameFormat, base::UTF8ToUTF16(product_name), NULL);