github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: log hint on renderer crash (#25473)

Browse Source 
* chore: log hint on renderer crash

* Address feedback from review

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot]
2020-09-15 14:01:31 -06:00
committed by GitHub
parent fe3378db92
commit 81c1a6ed29
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/browser/api/web-contents.js
View File

@@ -459,6 +459,11 @@ const addReturnValueToEvent = (event) => {
});
};
const loggingEnabled = () => {
return Object.prototype.hasOwnProperty.call(process.env, 'ELECTRON_ENABLE_LOGGING') ||
process.argv.some(arg => arg.toLowerCase().startsWith('--enable-logging'));
};
// Add JavaScript wrappers for WebContents class.
WebContents.prototype._init = function () {
// The navigation controller.
@@ -525,6 +530,11 @@ WebContents.prototype._init = function () {
this.on('crashed', (event, ...args) => {
app.emit('renderer-process-crashed', event, this, ...args);
// Log out a hint to help users better debug renderer crashes.
if (loggingEnabled()) {
console.info('Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.');
}
});
this.on('render-process-gone', (event, ...args) => {