github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 23:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: pass gfx::ResizeEdge by value (#46935)

Browse Source 
refactor: pass gfx::ResizeEdge by value

It is an enum class, so no reason to pass by reference
This commit is contained in:
Charles Kerr
2025-05-06 11:57:53 -05:00
committed by GitHub
parent 206544cbc0
commit 8308ac29c8
7 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_base_window.cc
View File

@@ -254,7 +254,7 @@ void BaseWindow::OnWindowRestore() {
}
void BaseWindow::OnWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge,
const gfx::ResizeEdge edge,
bool* prevent_default) {
v8::Isolate* isolate = JavascriptEnvironment::GetIsolate();
v8::HandleScope handle_scope(isolate);

2
shell/browser/api/electron_api_base_window.h
View File

@@ -71,7 +71,7 @@ class BaseWindow : public gin_helper::TrackableObject<BaseWindow>,
void OnWindowMinimize() override;
void OnWindowRestore() override;
void OnWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge,
gfx::ResizeEdge edge,
bool* prevent_default) override;
void OnWindowResize() override;
void OnWindowResized() override;

2
shell/browser/native_window.cc
View File

@@ -602,7 +602,7 @@ void NativeWindow::NotifyWindowRestore() {
}
void NativeWindow::NotifyWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge,
const gfx::ResizeEdge edge,
bool* prevent_default) {
observers_.Notify(&NativeWindowObserver::OnWindowWillResize, new_bounds, edge,
prevent_default);

2
shell/browser/native_window.h
View File

@@ -319,7 +319,7 @@ class NativeWindow : public base::SupportsUserData,
void NotifyWindowRestore();
void NotifyWindowMove();
void NotifyWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge,
gfx::ResizeEdge edge,
bool* prevent_default);
void NotifyWindowResize();
void NotifyWindowResized();

2
shell/browser/native_window_observer.h
View File

@@ -78,7 +78,7 @@ class NativeWindowObserver : public base::CheckedObserver {
virtual void OnWindowMinimize() {}
virtual void OnWindowRestore() {}
virtual void OnWindowWillResize(const gfx::Rect& new_bounds,
const gfx::ResizeEdge& edge,
gfx::ResizeEdge edge,
bool* prevent_default) {}
virtual void OnWindowResize() {}
virtual void OnWindowResized() {}

2
shell/common/gin_converters/gfx_converter.cc
View File

@@ -197,7 +197,7 @@ v8::Local<v8::Value> Converter<display::Display>::ToV8(
v8::Local<v8::Value> Converter<gfx::ResizeEdge>::ToV8(
v8::Isolate* isolate,
const gfx::ResizeEdge& val) {
const gfx::ResizeEdge val) {
switch (val) {
case gfx::ResizeEdge::kRight:
return StringToV8(isolate, "right");

2
shell/common/gin_converters/gfx_converter.h
View File

@@ -77,7 +77,7 @@ struct Converter<display::Display> {
template <>
struct Converter<gfx::ResizeEdge> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
const gfx::ResizeEdge& val);
const gfx::ResizeEdge val);
};
template <>