github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: do not run spellchecker tests if the feature is disabled (9-x-y) (#23724)

Browse Source 
* test: do not run SpellChecker tests if the features is disabled at build time

* fixup! test: do not run SpellChecker tests if the features is disabled at build time

* fixup! test: do not run SpellChecker tests if the features is disabled at build time
This commit is contained in:
Alexey Kuzmin
2020-05-23 20:05:37 +02:00
committed by GitHub
parent 98033f8520
commit 8803c12715
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/common/api/features.cc
View File

@@ -9,6 +9,10 @@
namespace {
bool IsBuiltinSpellCheckerEnabled() {
return BUILDFLAG(ENABLE_BUILTIN_SPELLCHECKER);
}
bool IsDesktopCapturerEnabled() {
return BUILDFLAG(ENABLE_DESKTOP_CAPTURER);
}
@@ -66,6 +70,7 @@ void Initialize(v8::Local<v8::Object> exports,
v8::Local<v8::Context> context,
void* priv) {
gin_helper::Dictionary dict(context->GetIsolate(), exports);
dict.SetMethod("isBuiltinSpellCheckerEnabled", &IsBuiltinSpellCheckerEnabled);
dict.SetMethod("isDesktopCapturerEnabled", &IsDesktopCapturerEnabled);
dict.SetMethod("isOffscreenRenderingEnabled", &IsOffscreenRenderingEnabled);
dict.SetMethod("isRemoteModuleEnabled", &IsRemoteModuleEnabled);

8
spec-main/spellchecker-spec.ts
View File

@@ -1,9 +1,11 @@
import { BrowserWindow, Session, session } from 'electron';
import { expect } from 'chai';
import { BrowserWindow, Session, session } from 'electron';
import { ifdescribe } from './spec-helpers';
import { closeWindow } from './window-helpers';
describe('spellchecker', () => {
const features = process.electronBinding('features');
ifdescribe(features.isBuiltinSpellCheckerEnabled())('spellchecker', () => {
let w: BrowserWindow;
beforeEach(async () => {

1
typings/internal-ambient.d.ts vendored
View File

@@ -9,6 +9,7 @@ declare const ENABLE_VIEW_API: boolean;
declare namespace NodeJS {
interface FeaturesBinding {
isBuiltinSpellCheckerEnabled(): boolean;
isDesktopCapturerEnabled(): boolean;
isOffscreenRenderingEnabled(): boolean;
isRemoteModuleEnabled(): boolean;