github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix a possible crash when destroying window.

Browse Source 
It could happend that the JS BrowserWindow object being double deleted
when calling the destroy() method.
This commit is contained in:
Cheng Zhao
2014-03-26 09:14:05 +08:00
parent 9ab3b5293c
commit 8b41e78245
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
atom/browser/api/atom_api_window.cc
View File

@@ -127,7 +127,9 @@ void Window::Destroy(const v8::FunctionCallbackInfo<v8::Value>& args) {
UNWRAP_WINDOW_AND_CHECK;
base::ProcessHandle handle = self->window_->GetRenderProcessHandle();
base::MessageLoop::current()->DeleteSoon(FROM_HERE, self);
// Just destroy the NativeWindow object, the api::Window object would be
// deleted in the coming OnWindowClosed event.
self->window_.reset();
// Make sure the renderer process is terminated, it could happen that the
// renderer process became a zombie.