github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tweak cookie set failure message and add spec

Browse Source
This commit is contained in:
Kevin Sawicki
2016-06-28 18:44:00 -07:00
parent 2cf0843f82
commit 8c52279531
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
atom/browser/api/atom_api_cookies.cc
View File

@@ -30,7 +30,7 @@ struct Converter<atom::api::Cookies::Error> {
if (val == atom::api::Cookies::SUCCESS)
return v8::Null(isolate);
else
return v8::Exception::Error(StringToV8(isolate, "failed"));
return v8::Exception::Error(StringToV8(isolate, "Setting cookie failed"));
}
};

11
spec/api-session-spec.js
View File

@@ -69,6 +69,17 @@ describe('session module', function () {
})
})
it('calls back with an error when setting a cookie with missing required fields', function (done) {
session.defaultSession.cookies.set({
url: '',
name: '1',
value: '1'
}, function (error) {
assert.equal(error.message, 'Setting cookie failed')
done()
})
})
it('should over-write the existent cookie', function (done) {
session.defaultSession.cookies.set({
url: url,