mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
fix: crash with creating OffScreenWebContentsView (#42940)
On the Mac platform, OffScreenWebContentsView uses Automatic Reference Counting (ARC) to handle the lifecycle of offScreenView_. However, this private member variable is not initialized and its value is undefined. In some cases, it is initialized to a garbage value, which may cause ARC to release the value incorrectly, resulting in a crash. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Jinli Wu <wujinli@bytedance.com>
This commit is contained in:
@@ -109,7 +109,7 @@ class OffScreenWebContentsView : public content::WebContentsView,
|
||||
raw_ptr<content::WebContents> web_contents_ = nullptr;
|
||||
|
||||
#if BUILDFLAG(IS_MAC)
|
||||
RAW_PTR_EXCLUSION OffScreenView* offScreenView_;
|
||||
RAW_PTR_EXCLUSION OffScreenView* offScreenView_ = nullptr;
|
||||
#endif
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user