github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused C string ToV8() gin converter (#44500)

Browse Source
This commit is contained in:
Charles Kerr
2024-11-01 18:11:46 -05:00
committed by GitHub
parent b985d8eb28
commit 9137d96ef4
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_web_contents.cc
View File

@@ -1344,7 +1344,7 @@ content::KeyboardEventProcessingResult WebContents::PreHandleKeyboardEvent(
}
void WebContents::ContentsZoomChange(bool zoom_in) {
Emit("zoom-changed", zoom_in ? "in" : "out");
Emit("zoom-changed", std::string_view{zoom_in ? "in" : "out"});
}
Profile* WebContents::GetProfile() {

8
shell/common/gin_converters/std_converter.h
View File

@@ -54,14 +54,6 @@ struct Converter<std::nullptr_t> {
}
};
template <>
struct Converter<const char*> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {
return v8::String::NewFromUtf8(isolate, val, v8::NewStringType::kNormal)
.ToLocalChecked();
}
};
template <>
struct Converter<char[]> {
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate, const char* val) {