github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 07:04:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: NodeBindings::Create() returns a unique_ptr (#43361)

Browse Source 
* refactor: NodeBindings::Create() returns a unique_ptr

* empty commit
This commit is contained in:
Charles Kerr
2024-08-20 14:34:59 -05:00
committed by GitHub
parent a2de94dda1
commit 93a6f3e607
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/common/node_bindings.h
View File

@@ -84,7 +84,7 @@ class NodeBindings {
public:
enum class BrowserEnvironment { kBrowser, kRenderer, kUtility, kWorker };
static NodeBindings* Create(BrowserEnvironment browser_env);
static std::unique_ptr<NodeBindings> Create(BrowserEnvironment browser_env);
static void RegisterBuiltinBindings();
static bool IsInitialized();

4
shell/common/node_bindings_linux.cc
View File

@@ -33,8 +33,8 @@ void NodeBindingsLinux::PollEvents() {
}
// static
NodeBindings* NodeBindings::Create(BrowserEnvironment browser_env) {
return new NodeBindingsLinux(browser_env);
std::unique_ptr<NodeBindings> NodeBindings::Create(BrowserEnvironment env) {
return std::make_unique<NodeBindingsLinux>(env);
}
} // namespace electron

4
shell/common/node_bindings_mac.cc
View File

@@ -41,8 +41,8 @@ void NodeBindingsMac::PollEvents() {
}
// static
NodeBindings* NodeBindings::Create(BrowserEnvironment browser_env) {
return new NodeBindingsMac(browser_env);
std::unique_ptr<NodeBindings> NodeBindings::Create(BrowserEnvironment env) {
return std::make_unique<NodeBindingsMac>(env);
}
} // namespace electron

4
shell/common/node_bindings_win.cc
View File

@@ -50,8 +50,8 @@ void NodeBindingsWin::PollEvents() {
}
// static
NodeBindings* NodeBindings::Create(BrowserEnvironment browser_env) {
return new NodeBindingsWin(browser_env);
std::unique_ptr<NodeBindings> NodeBindings::Create(BrowserEnvironment env) {
return std::make_unique<NodeBindingsWin>(env);
}
} // namespace electron