mirror of
https://github.com/electron/electron.git
synced 2026-01-25 15:28:11 -05:00
Enable context isolation on child windows
This commit is contained in:
@@ -47,6 +47,11 @@ const mergeBrowserWindowOptions = function (embedder, options) {
|
||||
options.webPreferences.nodeIntegration = false
|
||||
}
|
||||
|
||||
// Enable context isolation on child window if enable on parent window
|
||||
if (embedder.getWebPreferences().contextIsolation === true) {
|
||||
options.webPreferences.contextIsolation = true
|
||||
}
|
||||
|
||||
// Sets correct openerId here to give correct options to 'new-window' event handler
|
||||
options.webPreferences.openerId = embedder.id
|
||||
|
||||
|
||||
@@ -1903,6 +1903,15 @@ describe('BrowserWindow module', function () {
|
||||
})
|
||||
w.loadURL('file://' + fixtures + '/api/isolated.html')
|
||||
})
|
||||
|
||||
it('enables context isolation on child windows', function (done) {
|
||||
app.once('browser-window-created', function (event, window) {
|
||||
assert.equal(window.webContents.getWebPreferences().contextIsolation, true)
|
||||
done()
|
||||
})
|
||||
|
||||
w.loadURL('file://' + fixtures + '/pages/window-open.html')
|
||||
})
|
||||
})
|
||||
|
||||
describe('offscreen rendering', function () {
|
||||
|
||||
Reference in New Issue
Block a user