github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-23 22:38:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove explicit nullptr and add clarifying comment.

Browse Source
This commit is contained in:
Andy Dill
2015-05-21 08:54:27 -07:00
parent dcbc6a127b
commit 9a768dd4f0
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
atom/common/crash_reporter/crash_reporter_win.cc
View File

@@ -54,7 +54,11 @@ void CrashReporterWin::InitBreakpad(const std::string& product_name,
if (waiting_event != INVALID_HANDLE_VALUE)
WaitForSingleObject(waiting_event, 1000);
breakpad_.reset(nullptr);
// ExceptionHandler() attaches our handler and ~ExceptionHandler() detaches
// it, so we must explicitly reset *before* we instantiate our new handler
// to allow any previous handler to detach in the correct order.
breakpad_.reset();
int handler_types = google_breakpad::ExceptionHandler::HANDLER_EXCEPTION |
google_breakpad::ExceptionHandler::HANDLER_PURECALL;
breakpad_.reset(new google_breakpad::ExceptionHandler(