chore: use noop ShouldAbortOnUncaughtException cb (#25792)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot]
2020-10-06 14:30:20 -07:00
committed by GitHub
parent c157521bd0
commit 9ce7d133d8

View File

@@ -435,6 +435,12 @@ node::Environment* NodeBindings::CreateEnvironment(
// crash message and location to CrashReports.
is.fatal_error_callback = V8FatalErrorCallback;
// We don't want to abort either in the renderer or browser processes.
// We already listen for uncaught exceptions and handle them there.
is.should_abort_on_uncaught_exception_callback = [](v8::Isolate*) {
return false;
};
if (browser_env_ == BrowserEnvironment::BROWSER) {
// Node.js requires that microtask checkpoints be explicitly invoked.
is.policy = v8::MicrotasksPolicy::kExplicit;