github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

notify devtools opened and closed once per lifetime

Browse Source
This commit is contained in:
deepak1556
2016-05-12 19:16:13 +05:30
parent 7e0918f95a
commit a01f8ba739
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
brightray/browser/inspectable_web_contents_impl.cc
View File

@@ -368,6 +368,9 @@ void InspectableWebContentsImpl::LoadCompleted() {
// If the devtools can dock, "SetIsDocked" will be called by devtools itself.
if (!can_dock_)
SetIsDocked(DispatchCallback(), false);
if (view_->GetDelegate())
view_->GetDelegate()->DevToolsOpened();
}
void InspectableWebContentsImpl::SetInspectedPageBounds(const gfx::Rect& rect) {
@@ -618,6 +621,9 @@ void InspectableWebContentsImpl::WebContentsDestroyed() {
for (const auto& pair : pending_requests_)
delete pair.first;
if (view_ && view_->GetDelegate())
view_->GetDelegate()->DevToolsClosed();
}
bool InspectableWebContentsImpl::AddMessageToConsole(

4
brightray/browser/inspectable_web_contents_view_mac.mm
View File

@@ -29,14 +29,10 @@ gfx::NativeView InspectableWebContentsViewMac::GetNativeView() const {
void InspectableWebContentsViewMac::ShowDevTools() {
[view_ setDevToolsVisible:YES];
if (GetDelegate())
GetDelegate()->DevToolsOpened();
}
void InspectableWebContentsViewMac::CloseDevTools() {
[view_ setDevToolsVisible:NO];
if (GetDelegate())
GetDelegate()->DevToolsClosed();
}
bool InspectableWebContentsViewMac::IsDevToolsViewShowing() {

4
brightray/browser/views/inspectable_web_contents_view_views.cc
View File

@@ -118,8 +118,6 @@ void InspectableWebContentsViewViews::ShowDevTools() {
devtools_web_view_->RequestFocus();
Layout();
}
if (GetDelegate())
GetDelegate()->DevToolsOpened();
}
void InspectableWebContentsViewViews::CloseDevTools() {
@@ -137,8 +135,6 @@ void InspectableWebContentsViewViews::CloseDevTools() {
devtools_web_view_->SetWebContents(NULL);
Layout();
}
if (GetDelegate())
GetDelegate()->DevToolsClosed();
}
bool InspectableWebContentsViewViews::IsDevToolsViewShowing() {