github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix hanlding trailing slash in asar package, close #2222

Browse Source
This commit is contained in:
Cheng Zhao
2015-07-16 03:48:35 -07:00
parent 78e55414d4
commit a2c26b8c74
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
atom/common/asar/archive.cc
View File

@@ -54,6 +54,11 @@ bool GetChildNode(const base::DictionaryValue* root,
const std::string& name,
const base::DictionaryValue* dir,
const base::DictionaryValue** out) {
if (name == "") {
*out = root;
return true;
}
const base::DictionaryValue* files = NULL;
return GetFilesNode(root, dir, &files) &&
files->GetDictionaryWithoutPathExpansion(name, out);

9
spec/asar-spec.coffee
View File

@@ -85,6 +85,11 @@ describe 'asar package', ->
done()
describe 'fs.lstatSync', ->
it 'handles path with trailing slash correctly', ->
p = path.join fixtures, 'asar', 'a.asar', 'link2', 'link2', 'file1'
fs.lstatSync p
fs.lstatSync p + '/'
it 'returns information of root', ->
p = path.join fixtures, 'asar', 'a.asar'
stats = fs.lstatSync p
@@ -136,6 +141,10 @@ describe 'asar package', ->
assert.throws throws, /ENOENT/
describe 'fs.lstat', ->
it 'handles path with trailing slash correctly', (done) ->
p = path.join fixtures, 'asar', 'a.asar', 'link2', 'link2', 'file1'
fs.lstat p + '/', done
it 'returns information of root', (done) ->
p = path.join fixtures, 'asar', 'a.asar'
stats = fs.lstat p, (err, stats) ->