github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: cherry-pick ec6c18478382 from v8 (#48339)

Browse Source 
* chore: cherry-pick ec6c18478382 from v8

* chore: update patches
This commit is contained in:
Keeley Hammond
2025-09-16 19:52:23 -07:00
committed by GitHub
parent edd0bc56df
commit a9214d4166
2 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
patches/v8/.patches
View File

@@ -1,2 +1,3 @@
chore_allow_customizing_microtask_policy_per_context.patch
enable_--perf-prof_flag_on_macos.patch
cherry-pick-ec6c18478382.patch

45
patches/v8/cherry-pick-ec6c18478382.patch Normal file
View File

@@ -0,0 +1,45 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Darius Mercadier <dmercadier@chromium.org>
Date: Tue, 16 Sep 2025 16:40:24 +0200
Subject: Don't assume that upper 32-bit of Int32MulOvfCheck are 0
Because Arm64 doesn't have a flag-setting 32-bit multiplication,
which means that instead with use a 64-bit multiplication, and compare
result.X() and result.W() to check if an overflow happened. But this
leads to the upper 32-bit not being zeroed.
Fixed: 445380761
Change-Id: I31287faf37dc615695047021324e9d1d802cbec2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6954290
Auto-Submit: Darius Mercadier <dmercadier@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102530}
diff --git a/src/compiler/backend/arm64/instruction-selector-arm64.cc b/src/compiler/backend/arm64/instruction-selector-arm64.cc
index baadca1fc907198b217d90f65d8663ac10a4c141..3c9168c067615f3b7cda9992280940b20e3f472f 100644
--- a/src/compiler/backend/arm64/instruction-selector-arm64.cc
+++ b/src/compiler/backend/arm64/instruction-selector-arm64.cc
@@ -2951,9 +2951,19 @@ bool InstructionSelectorT::ZeroExtendsWord32ToWord64NoPhis(OpIndex node) {
return op.Cast<ShiftOp>().rep == WordRepresentation::Word32();
case Opcode::kComparison:
return op.Cast<ComparisonOp>().rep == RegisterRepresentation::Word32();
- case Opcode::kOverflowCheckedBinop:
- return op.Cast<OverflowCheckedBinopOp>().rep ==
- WordRepresentation::Word32();
+ case Opcode::kOverflowCheckedBinop: {
+ const OverflowCheckedBinopOp& binop = op.Cast<OverflowCheckedBinopOp>();
+ if (binop.rep != WordRepresentation::Word32()) return false;
+ switch (binop.kind) {
+ case OverflowCheckedBinopOp::Kind::kSignedAdd:
+ case OverflowCheckedBinopOp::Kind::kSignedSub:
+ return true;
+ case OverflowCheckedBinopOp::Kind::kSignedMul:
+ // EmitInt32MulWithOverflow doesn't zero-extend because Arm64 doesn't
+ // have a flag-setting int32 multiplication.
+ return false;
+ }
+ }
case Opcode::kProjection:
return ZeroExtendsWord32ToWord64NoPhis(op.Cast<ProjectionOp>().input());
case Opcode::kLoad: {