github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: check WebContents in OnGetDefaultPrinter (#22475)

Browse Source 
Co-authored-by: Cheng Zhao <zcbenz@electronjs.org>
This commit is contained in:
trop[bot]
2020-03-03 15:05:21 +09:00
committed by GitHub
parent 6e4690574d
commit ae639186e3
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shell/browser/api/electron_api_web_contents.cc
View File

@@ -1737,6 +1737,14 @@ void WebContents::OnGetDefaultPrinter(
base::string16 device_name,
bool silent,
base::string16 default_printer) {
// The content::WebContents might be already deleted at this point, and the
// PrintViewManagerBasic class does not do null check.
if (!web_contents()) {
if (print_callback)
std::move(print_callback).Run(false, "failed");
return;
}
base::string16 printer_name =
device_name.empty() ? default_printer : device_name;
print_settings.SetStringKey(printing::kSettingDeviceName, printer_name);