github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-27 16:28:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reduce the number of helpers

Browse Source
This commit is contained in:
Cheng Zhao
2017-12-20 10:49:49 +09:00
parent 4fd8b04329
commit b2e6340622
2 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
atom/browser/web_contents_permission_helper.cc
View File

@@ -53,13 +53,6 @@ WebContentsPermissionHelper::~WebContentsPermissionHelper() {
}
void WebContentsPermissionHelper::RequestPermission(
content::PermissionType permission,
const base::Callback<void(bool)>& callback,
bool user_gesture) {
RequestPermissionWithDetails(permission, callback, user_gesture, nullptr);
}
void WebContentsPermissionHelper::RequestPermissionWithDetails(
content::PermissionType permission,
const base::Callback<void(bool)>& callback,
bool user_gesture,
@@ -107,7 +100,7 @@ void WebContentsPermissionHelper::RequestOpenExternalPermission(
const GURL& url) {
base::DictionaryValue details;
details.SetString("externalURL", url.spec());
RequestPermissionWithDetails(
RequestPermission(
static_cast<content::PermissionType>(PermissionType::OPEN_EXTERNAL),
callback, user_gesture, &details);
}

8
atom/browser/web_contents_permission_helper.h
View File

@@ -43,12 +43,8 @@ class WebContentsPermissionHelper
void RequestPermission(
content::PermissionType permission,
const base::Callback<void(bool)>& callback,
bool user_gesture = false);
void RequestPermissionWithDetails(
content::PermissionType permission,
const base::Callback<void(bool)>& callback,
bool user_gesture,
const base::DictionaryValue* details);
bool user_gesture = false,
const base::DictionaryValue* details = nullptr);
content::WebContents* web_contents_;