github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-25 23:38:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Disable deprecation warning of crashReported.setExtraParameter()

Browse Source 
It caused a couple of Crash Reported tests to timeout on Mac.
Task to enable it back:
https://github.com/electron/electron/issues/11012
This commit is contained in:
Aleksei Kuzmin
2017-11-04 07:45:22 +03:00
parent 8736a41cfb
commit b3a1fc65e5
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/common/api/crash-reporter.js
View File

@@ -106,10 +106,14 @@ class CrashReporter {
// TODO(2.0) Remove
setExtraParameter (key, value) {
if (!process.noDeprecations) {
deprecate.warn('crashReporter.setExtraParameter',
'crashReporter.addExtraParameter or crashReporter.removeExtraParameter')
}
// TODO(alexeykuzmin): Warning disabled since it caused
// a couple of Crash Reported tests to time out on Mac. Add it back.
// https://github.com/electron/electron/issues/11012
// if (!process.noDeprecations) {
// deprecate.warn('crashReporter.setExtraParameter',
// 'crashReporter.addExtraParameter or crashReporter.removeExtraParameter')
// }
binding.setExtraParameter(key, value)
}