github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: update ElectronBrowserClient w/upstream API

Browse Source 
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797454

tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
This commit is contained in:
Charles Kerr
2021-04-04 10:24:04 -05:00
committed by Samuel Attard
parent 6fe734f5ca
commit b760f7162b
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shell/browser/electron_browser_client.cc
View File

@@ -1204,9 +1204,9 @@ content::MediaObserver* ElectronBrowserClient::GetMediaObserver() {
return MediaCaptureDevicesDispatcher::GetInstance();
}
content::DevToolsManagerDelegate*
ElectronBrowserClient::GetDevToolsManagerDelegate() {
return new DevToolsManagerDelegate;
std::unique_ptr<content::DevToolsManagerDelegate>
ElectronBrowserClient::CreateDevToolsManagerDelegate() {
return std::make_unique<DevToolsManagerDelegate>();
}
NotificationPresenter* ElectronBrowserClient::GetNotificationPresenter() {

3
shell/browser/electron_browser_client.h
View File

@@ -171,7 +171,8 @@ class ElectronBrowserClient : public content::ContentBrowserClient,
cert_verifier_creation_params) override;
network::mojom::NetworkContext* GetSystemNetworkContext() override;
content::MediaObserver* GetMediaObserver() override;
content::DevToolsManagerDelegate* GetDevToolsManagerDelegate() override;
std::unique_ptr<content::DevToolsManagerDelegate>
CreateDevToolsManagerDelegate() override;
content::PlatformNotificationService* GetPlatformNotificationService(
content::BrowserContext* browser_context) override;
std::unique_ptr<content::BrowserMainParts> CreateBrowserMainParts(