github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix typos in comments (#29519)

Browse Source 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
This commit is contained in:
trop[bot]
2021-06-03 01:00:01 -07:00
committed by GitHub
parent 4e610b1948
commit c2877a342c
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/api/electron_api_web_request.cc
View File

@@ -387,7 +387,7 @@ void WebRequest::SetListener(Event event,
std::set<std::string> filter_patterns;
gin::Dictionary dict(args->isolate());
if (args->GetNext(&arg) && !arg->IsFunction()) {
// Note that gin treats Function as Dictionary when doing convertions, so we
// Note that gin treats Function as Dictionary when doing conversions, so we
// have to explicitly check if the argument is Function before trying to
// convert it to Dictionary.
if (gin::ConvertFromV8(args->isolate(), arg, &dict)) {

2
shell/browser/ui/accelerator_util.h
View File

@@ -23,7 +23,7 @@ typedef std::map<ui::Accelerator, MenuItem> AcceleratorTable;
bool StringToAccelerator(const std::string& shortcut,
ui::Accelerator* accelerator);
// Generate a table that contains memu model's accelerators and command ids.
// Generate a table that contains menu model's accelerators and command ids.
void GenerateAcceleratorTable(AcceleratorTable* table,
electron::ElectronMenuModel* model);

4
shell/common/gin_helper/callback.h
View File

@@ -14,7 +14,7 @@
#include "shell/common/gin_helper/function_template.h"
#include "shell/common/gin_helper/locker.h"
#include "shell/common/gin_helper/microtasks_scope.h"
// Implements safe convertions between JS functions and base::RepeatingCallback.
// Implements safe conversions between JS functions and base::RepeatingCallback.
namespace gin_helper {
@@ -110,7 +110,7 @@ struct V8FunctionInvoker<ReturnType(ArgTypes...)> {
}
};
// Helper to pass a C++ funtion to JavaScript.
// Helper to pass a C++ function to JavaScript.
using Translater = base::RepeatingCallback<void(gin::Arguments* args)>;
v8::Local<v8::Value> CreateFunctionFromTranslater(v8::Isolate* isolate,
const Translater& translater,

2
shell/common/gin_helper/function_template.h
View File

@@ -96,7 +96,7 @@ bool GetNextArgument(gin::Arguments* args,
}
// Support base::Optional as output, which would be empty and do not throw error
// when convertion to T fails.
// when conversion to T fails.
template <typename T>
bool GetNextArgument(gin::Arguments* args,
int create_flags,